-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI task run input page is misleading #6627
Comments
I worry this might get overlooked as it has a ui label but the issue is actually coming from the api. So updating the labels. Let me know if you think it needs any ui action @madkinsz |
Can someone clarify what the expected behavior is here? Is it expected in general that the Task Inputs should show the actual values that were passed into a task? Similarly, if a task has an output, is its value expected to show up in the interface? |
The expected behavior would be for the API to account for the |
@zhen0 I feel like tracking the other types of inputs is a separate ticket. This is explicitly about the lack of context for what this is expected to contain. Notably #7547 incorrectly says
The values should not be empty if the task was passed a value from one or more upstream tasks. In that case, the upstream task run ids would be referenced in the list. |
For example from prefect import flow, task
@task
def identity(x):
return x
@flow()
def exampleflow():
# Create some futures
one = identity.submit(1)
two = identity.submit(2)
three = identity.submit(3)
identity(one)
identity([two, three])
identity(1)
identity([2, 3])
exampleflow() Here's the task run that receives one upstream future for Here's the task run that receives two upstream futures for |
Thanks @madkinsz - I'm adding back the needs triage label so that I can come back and triage this tomorrow. |
This topic came up in our team in a production debug scenario today. It would be a nice quick win to have a description here. People not that familiar with the internal Prefect mechanism get confused. In our case, the Prefect flow operators execute business deliveries with the flows. These are our primary stakeholders beneath the engineers implementing flows. Getting them clear will help them and us as a platform team. Thank you! |
#8295 should have addressed this |
First check
Prefect Version
2.x
Describe the proposed behavior
The task run inputs page should include a description of what contents are expected to appear. For example, clarifying that only relationships between tasks are tracked here.
In the future, Prefect should do some sort of minimal tracking of the actual data passed between tasks so it can be displayed in the UI. However, that feature should be a separate ticket.
Until then, we should explain what a user should expect to see on this page.
Describe the current behavior
The task run page added in https://github.com/PrefectHQ/nebula-ui/pull/1538 / #6570 includes a task inputs tab. This tab does not include the input values to my task.
For a simple flow:
My task receives the value "Marvin" for the
name
parameter but this is not captured by the API.Example Use
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: