Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library no longer works with PHP7.4 #48

Closed
timramakers opened this issue Jan 20, 2023 · 4 comments
Closed

Library no longer works with PHP7.4 #48

timramakers opened this issue Jan 20, 2023 · 4 comments

Comments

@timramakers
Copy link

The 'mixed' pseudotype is used in the last commit, seemingly added for PHP8 compatibility. This is not available in PHP7.4 and throws a fatal error.

This caused all of our client's applications to break. Therefore, we are moving away from this PHP library since it's not reliable.

To improve in the future:

  • please create releases so we users have control over which version we are using. Using dev-master in composer.json is not acceptable for any kind of production environment;
  • please test in all supported versions of PHP before putting out a new release.
@DjThossi
Copy link

DjThossi commented Feb 9, 2023

I agree the last commit was not a good idea in master branch. The Person pushed up the PHP version in composer.json to 7 and used PHP 8 features in the same commit. This breaks the whole idea of the composer.json.

@Izet0004
Copy link

Izet0004 commented Feb 16, 2023

Same problem here..

If anyone want's a quick fix

Edit line 105 inside Entity.php and remove the "mixed" return type

This should not be taken as a permanent fix

@cesar1983
Copy link

cesar1983 commented Aug 25, 2023

The problem with this library is that you don´t release versions. You must start releasing versions to avoid this situation.

@DjThossi
Copy link

DjThossi commented Sep 18, 2023

Please tag branch dev-release/2.0.0 with tag 2.0.0

It will solve our problems. @PrintNodeLtd PLEASE!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants