-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latte: Fixed exponential backtracking #2682
Latte: Fixed exponential backtracking #2682
Conversation
Is the detector improving or this was just not dealt with before? |
This is one of the very few regexes that aren't checked by our detector. This was found using a CodeQL query. |
I'll assume it's something weird about how markup templating works or something that it's "special"... so much of our regex are generated at run-time but since the tests are running at run-time we just hook into the FINAL prepared regex and run them thru the checker. |
Yeah, we just check the regexes of all grammars. Markup templating also needs one additional regex to detect the embedded language and that regex isn't checked. One way around that might be to override the |
No description provided.