Add Nginx #776
Merged
Add Nginx #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing! Would you mind adding an example file, that reflects most of the features and flaws, following the format of the existing ones ? |
|
Also, please keep your changes on separated branches, so that this PR contains only Nginx-related stuff. You just pushed vim support ^^ |
|
|
||
| Prism.languages.nginx = Prism.languages.extend('clike', { | ||
| comment: { | ||
| pattern: /(^|[^"{\\])(#.*?(\r?\n|$))/, |
There was a problem hiding this comment.
I think you'll need a lookbehind: true here, so that no char is consumed before the comment.
Also, you probably don't need the last group ; /(^|[^"{\\])#.*/ should be enough (since it does not match line feeds).
|
I did a quick review. Please take a look at my inline comments. |
Golmote
added a commit
that referenced
this pull request
Sep 23, 2015
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Nginx highlighting.
Extracted from this gist https://gist.github.com/misiek08/6566480