Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate hints parameter #4741

Open
TheMarex opened this issue Dec 17, 2017 · 1 comment
Open

Deprecate hints parameter #4741

TheMarex opened this issue Dec 17, 2017 · 1 comment
Labels
Milestone

Comments

@TheMarex
Copy link
Member

The hints parameter is probably one of the worst concepts of our API that exposes internal data structures to the client and allows them to pass this information back to us. This breaks a few encapsulations, means we need to ship a clunky Base64 encoder and have our internal PhantomNode size impact the size of our response objects.

It is straight forward to remove this parameter from the HTTP API but the C++ API is another problem.
Since we encode internal state in the Hints object that is part of a public interface, we can't just remove this class. I don't see an easy way to do this without breaking the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants