Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adapter SSR pages are rendering with incorrect content type header #1137

Closed
thescientist13 opened this issue Aug 7, 2023 · 0 comments · Fixed by #1138 or #1120
Closed

adapter SSR pages are rendering with incorrect content type header #1137

thescientist13 opened this issue Aug 7, 2023 · 0 comments · Fixed by #1138 or #1120
Assignees
@thescientist13
Labels
Adapter alpha.2 bug Something isn't working CLI SSR v0.29.0
Milestone
1.0

Comments

@thescientist13
Copy link
Member

thescientist13 commented Aug 7, 2023 •
edited
Loading

Type of Change

Bug

Summary

Noticed as part of some serverless work that SSR pages were not returning the correct content-type. It should be text/html, instead it is text/plain.
https://greenwood-demo-adapter-vercel-git-adapte-7d5372-the-green-lodge.vercel.app/artists/
Screen Shot 2023-08-06 at 8 00 26 PM

Details

This fix will target the v0.29.0-alpha.x branch for now since i think it this bug is only impactful to that release line and specific to adapted output, but can certainly backport to v0.28.x if needed.
@thescientist13 thescientist13 added this to the 1.0 milestone Aug 7, 2023
@thescientist13 thescientist13 mentioned this issue Aug 7, 2023
Merged
1 task
@thescientist13 thescientist13 linked a pull request Aug 7, 2023 that will close this issue
bug/issue 1137 have adapted SSR pages return text/html content type #1138
Merged
1 task
@thescientist13 thescientist13 changed the title SSR pages are rendering with incorrect content type header (serverless) SSR pages are rendering with incorrect content type header Aug 7, 2023
@thescientist13 thescientist13 self-assigned this Aug 7, 2023
@thescientist13 thescientist13 changed the title (serverless) SSR pages are rendering with incorrect content type header adapter SSR pages are rendering with incorrect content type header Aug 7, 2023
@thescientist13 thescientist13 mentioned this issue Aug 10, 2023
Merged
25 tasks
@thescientist13 thescientist13 linked a pull request Aug 10, 2023 that will close this issue
release/0.29.0 #1120
Merged
25 tasks
This was referenced Aug 12, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thescientist13 thescientist13

Labels
Adapter alpha.2 bug Something isn't working CLI SSR v0.29.0
Projects
No open projects
[Greenwood] Phase 9 - Standards and Conventions
Status: ✅ Done
Milestone
1.0
1 participant
@thescientist13