Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website shelf not showing when loading a deep link with more than one route segment (from the shelf) #297

Closed
2 of 5 tasks
thescientist13 opened this issue Mar 7, 2020 · 1 comment · Fixed by #298 or #302
Closed
2 of 5 tasks
Assignees
Labels
bug Something isn't working v0.5.0 Data w/ GraphQL website Tasks related to the projects website / documentation

Comments

@thescientist13
Copy link
Member

thescientist13 commented Mar 7, 2020

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

When loading a route directly with a routing depth of greater than one segment, e.g. _/docs/configuration, where that second segment is coming from the shelf, the shelf doesn't show at all and there are no console errors.

Screen Shot 2020-03-07 at 4 52 06 PM

Details

Steps to reproduce

  1. Got to the docs page
  2. Expand configuration
  3. The URL should now have show this: https://www.greenwoodjs.io/docs/configuration
  4. Copy / paste that URL into a new browser tab

Expected

The shelf would show on the left, expanded to the correct spot

Actual

The shelf does not show. (you can see it flash for a second)

Observations

  • This doesn't seem to happen in develop or serve mode, only when using build on Netlify
  • Likely related to add support for dynamic imports  #275 but just need to confirm first
  • This all happens in the release/0.5.0 branch this happens too, but the loading of cache.json is also breaking

Screen Shot 2020-03-07 at 4 59 40 PM

@thescientist13 thescientist13 added bug Something isn't working website Tasks related to the projects website / documentation labels Mar 7, 2020
@thescientist13
Copy link
Member Author

I went back one commit on master and was able to confirm the prior behavior by using the following test

$ yarn build && cd public &&  npx http-server
  • Page loads
  • Shelf loads
  • Shelf does not expand though (but all sub items are present)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v0.5.0 Data w/ GraphQL website Tasks related to the projects website / documentation
Projects
None yet
1 participant