Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure proper termination of server plugins when Greenwood process ends #539

Open
1 of 5 tasks
thescientist13 opened this issue Apr 11, 2021 · 1 comment
Open
1 of 5 tasks
Labels
CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) good first issue Good for newcomers Plugins Greenwood Plugins
Milestone

Comments

@thescientist13
Copy link
Member

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

Should really import the stop methods for both servers in Greenwood. This is especially true for the live dev server, something the process does get shut down correctly and then an error could show with the live reload server still running in the background.

Details

This would apply to:

Need to make sure there stop methods get called and appropriately shut everything both down, with the main use case being when a user does something like ctr+c to kill the dev server and so we would probably want to listen for a process exit callback?

Not sure if this could also be helpful for unit testing the dev server for #47 ?

@thescientist13 thescientist13 added Plugins Greenwood Plugins CLI labels Apr 11, 2021
@thescientist13 thescientist13 added this to the 1.0 milestone Apr 11, 2021
@thescientist13 thescientist13 added good first issue Good for newcomers enhancement Improve something existing (e.g. no docs, new APIs, etc) labels Apr 11, 2021
@thescientist13 thescientist13 removed this from the 1.0 milestone Mar 15, 2022
@thescientist13
Copy link
Member Author

Would also add for a build task, since we start servers for pre-rendering, this means we have to use process.exit in CLI entry point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) good first issue Good for newcomers Plugins Greenwood Plugins
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant