You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Added Prettier formating in #24 which should be running Prettier on commit. However, as just recently observed in #50 , the build was failing on the npm run format:check task on the root level CONTRIBUTING.md
Run npm run format:check
> www.greenwoodjs.dev@0.0.1 format:check
> prettier . --check
Checking formatting...
[warn] CONTRIBUTING.md
[warn] Code style issues found in the above file. Run Prettier to fix.
Error: Process completed with exit code 1.
but that should already be running as this is what we have in our package.json right?
"lint-staged": {
"*.js": "npm run lint:js",
"*.css": "npm run lint:css",
"**/*": "npm run lint:ls && npm run format"
}
Details
Can confirm that after running npm run format locally, the file showed up as having needed formatting. 🤷♂️
maybe we should just bail on it as a pre-commit hook, and just run format in CI, then let developers choose when to deal with the formatting themselves?
thescientist13
changed the title
prettier formating not working with lint staged
prettier formatting not working with lint staged
Sep 5, 2024
Summary
Added Prettier formating in #24 which should be running Prettier on commit. However, as just recently observed in #50 , the build was failing on the
npm run format:check
task on the root level CONTRIBUTING.mdbut that should already be running as this is what we have in our package.json right?
Details
Can confirm that after running
npm run format
locally, the file showed up as having needed formatting. 🤷♂️The text was updated successfully, but these errors were encountered: