Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Fix tip amount scaling in fulfillOrders #559

Merged

Conversation

frankisawesome
Copy link
Contributor

Motivation

Fixes #558

Solution

Signed-off-by: Frank Li <b439988l@gmail.com>
Signed-off-by: Frank Li <b439988l@gmail.com>
src/seaport.ts Outdated Show resolved Hide resolved
src/seaport.ts Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2024

Codecov Report

Attention: Patch coverage is 99.16667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 98.41%. Comparing base (f618d19) to head (74cdd01).
Report is 62 commits behind head on main.

Files Patch % Lines
src/seaport.ts 97.05% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #559      +/-   ##
==========================================
+ Coverage   98.27%   98.41%   +0.13%     
==========================================
  Files          35       35              
  Lines       14526    14955     +429     
  Branches      660      671      +11     
==========================================
+ Hits        14276    14718     +442     
+ Misses        245      232      -13     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Frank Li <b439988l@gmail.com>
Signed-off-by: Frank Li <b439988l@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scale tip amounts to partial fills when using fulfillOrders (fulfillAvailableAdvancedOrders)
3 participants