Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Improve error messaging for failed balance/approval checks #594

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

frankisawesome
Copy link
Contributor

Motivation

It's tough developer experience when prompted with the previous error message, resulting in quite some tinkling in my case, using npm link and logging things out to debug what's gone wrong in my set up. The change allows developers to find the cause of the balance/approval check fail at a glance.

Solution

Signed-off-by: Frank Li <b439988l@gmail.com>
Signed-off-by: Frank Li <b439988l@gmail.com>
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.67%. Comparing base (f618d19) to head (fc4f6b0).
Report is 91 commits behind head on main.

Files Patch % Lines
src/utils/balanceAndApprovalCheck.ts 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #594      +/-   ##
==========================================
+ Coverage   98.27%   98.67%   +0.39%     
==========================================
  Files          35       35              
  Lines       14526    15651    +1125     
  Branches      660      690      +30     
==========================================
+ Hits        14276    15444    +1168     
+ Misses        245      202      -43     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryanio ryanio merged commit 099bd10 into ProjectOpenSea:main Jul 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants