Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change point information -> use "submission comment" instead of "comment" on reference points (publicly available) #355

Closed
mlocardpaulet opened this issue Sep 3, 2024 · 4 comments
Assignees

Comments

@mlocardpaulet
Copy link
Contributor

When we publicly upload a run, we save the comment in the "additional information" field and in the "submission comment" field.
In the end, the first one is chosen to be visualised when we hover on the plot.
Isn't it weird? I would select the second comment (the one that we make at public submission). In my mind the first one was more for local visualisation. No?

Either way it has to be clear in the description. Currently, there are inconsistency in the comments (because I did not care about the first "additional information" comment).

@mlocardpaulet
Copy link
Contributor Author

To be honest, I think that we should remove the "additional information" altogether. I think that it is confusing. People think that they need to fill it out.

@mlocardpaulet
Copy link
Contributor Author

mlocardpaulet commented Sep 3, 2024

Conclusion of our discussion on the topic:

  • the comment that should be visible when hovering on the plot is the submission comment, not the comment that can be made in the initial "additional information" panel.
  • we will remove the entire "additional information" panel, and only keep one field for a comment that does not need to be kept at the public submission step.

@scaramonche
Copy link
Contributor

see #382

@scaramonche
Copy link
Contributor

Working on the second point in #384.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants