Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Regular Files API to reflect new add / addAll distinctions #498

Open
terichadbourne opened this issue Jul 29, 2020 · 1 comment
Open
Labels
blocked bug Something isn't working

Comments

@terichadbourne
Copy link
Member

BLOCKED

We've done what we can to update the text of the Regular Files API tutorial to reflect the intended usage of the add and addAll, but in actually they both appear to be accepting both single file objects and arrays of file objects. The js-ipfs team is still finalizing how these methods will work and what will throw errors, so we'll need to update our validation once that's been settled.

See related js-ipfs issues:
ipfs/js-ipfs#3195
ipfs/js-ipfs#3188

@achingbrain can you please update us when things settle out on your end so we can make the appropriate updates in our validation?

@terichadbourne terichadbourne added enhancement New feature or request blocked labels Jul 29, 2020
@terichadbourne terichadbourne added bug Something isn't working and removed enhancement New feature or request labels Jul 29, 2020
@terichadbourne
Copy link
Member Author

@achingbrain Just checking in to see if there's been any movement on what add and addAll will actually accept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant