Fixes delete roms and a few other various menu actions #2365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on returning the correct path for a game, such as move rom to system). We were computing the directory for the ROM incorrectly, so it was never being found.
|
rejecting because I had the same change but slightly different using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any action relying on PVEmulatorCongifuration returning the correct path for a game would fail, because it was returning the wrong path. We were computing the directory for the ROM incorrectly, so it was never being found.
What does this PR do
Fixes the computation of the path for a give Game. actions relying on that such as Delete and Move ROM should work properly now.
Where should the reviewer start
How should this be manually tested
Test Delete Rom, move rom, etc.
Any background context you want to provide
What are the relevant tickets
Screenshots (important for UI changes)
Questions