Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snake demo does not work with Mill 0.10.2 #355

Closed
davesmith00000 opened this issue Mar 27, 2022 · 7 comments
Closed

Snake demo does not work with Mill 0.10.2 #355

davesmith00000 opened this issue Mar 27, 2022 · 7 comments
Labels
wontfix This will not be worked on workaround

Comments

@davesmith00000
Copy link
Member

It looks like the fastOpt file has been renamed from out.js to main.js...?
@davesmith00000 davesmith00000 added workaround wontfix This will not be worked on labels Apr 27, 2022
@davesmith00000
Copy link
Member Author

Followed up on this: Mill 0.10.3 is also not working but it's now a problem with the way Mill handles module kinds (ESModule/CommonJSModule).

Indigo has a PR ready to go that includes a less brittle method of finding the right file to use from the right location as described in the original comment.

@lolgab has a fix ready to go, just needs to be released.

Everyone should use Mill 0.10.0 until then.

@davesmith00000 davesmith00000 mentioned this issue Apr 27, 2022
Merged
@lolgab
Copy link
Contributor

lolgab commented Apr 27, 2022

This will be fixed once com-lihaoyi/mill#1851 is merged

@lolgab
Copy link
Contributor

lolgab commented May 3, 2022

Mill 0.10.3-36-e038bb contains the fix. Can you try to see if it solves your problem?

@davesmith00000
Copy link
Member Author

Will do - will give it a shot this evening. 👍

@davesmith00000
Copy link
Member Author

@lolgab Works perfectly 🎉
Sorry about the delay coming back to you.

@lolgab
Copy link
Contributor

lolgab commented May 6, 2022

No worries :)

@davesmith00000
Copy link
Member Author

Fixed on main branch by upgrading to Mill 0.10.4, will go out with the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix This will not be worked on workaround
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davesmith00000 @lolgab