Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow newer versions of importlib-metadata #1522

Closed
kasium opened this issue Jan 17, 2022 · 4 comments
Closed

Allow newer versions of importlib-metadata #1522

kasium opened this issue Jan 17, 2022 · 4 comments

Comments

@kasium
Copy link
Contributor

kasium commented Jan 17, 2022

flake8 currently pins importlib-metadata<4.3;python_version<"3.8", but e.g. sphinx needs a newer version importlib-metadata>=4.4; python_version < '3.10'. Can we allow flake8 to consume newer versions?

@MarcoGorelli
Copy link

Hey - from #1438 this seems unlikely, I'd suggest closing this to reduce the load on the maintainers

@kasium
Copy link
Contributor Author

kasium commented Jan 17, 2022

Okay, I read thru the thread, but how should this now move on? Should I ask sphinx to relax their pin?

@MarcoGorelli
Copy link

One suggestion could be to run flake8 via pre-commit, so it runs in its own virtual environment and there's no dependency clash

Should I ask sphinx to relax their pin?

Could do, but check if it's been asked already first

@sigmavirus24
Copy link
Member

If you can, use something that isolates your different tools for you. There are lots of things that do this:

  • pipx
  • nox
  • rox
  • virtualenv
  • pre-commit
  • and plenty more I probably don't know about or have forgotten

@PyCQA PyCQA locked and limited conversation to collaborators Jan 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants