Fix abs path pylint #248
Merged
Fix abs path pylint #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .pre-commit-config.yaml
chocoelho
force-pushed
the
fix-abs-path-pylint
branch
from
da02f66
to
6522182
Compare
Mock argv before calling ProspectorConfig in tests
chocoelho
force-pushed
the
fix-abs-path-pylint
branch
from
8504e0c
to
e66b1a2
Compare
Signed-off-by: Carlos Coêlho <carlospecter@gmail.com>
chocoelho
force-pushed
the
fix-abs-path-pylint
branch
from
2796ab1
to
12e1436
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prospector has an issue with absolute paths, since using the current approach would produce an invalid package path, e.g.,
/home/xpto/file.pywould becomehome/xpto/file.pydue to how the split is handled on prospector/tools/pylint/__init__.py#L114.With the following change, it can easily handle both relative and absolute paths gracefully. Also, pylint plugins were removed due to the reason that it shouldn't be prospector concern to have pylint plugins that depend upon other frameworks such as Django or Flask. Resolves #245.