Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Vulture API usage for newer versions of Vulture #390

Merged
merged 1 commit into from
Aug 22, 2020

Conversation

carlio
Copy link
Contributor

@carlio carlio commented Jul 8, 2020

Fixes #689 - just removes the unused 'excludes' keyword and also adapts the line number.

@chocoelho have a quick look if you get time, it seems to work for me

…(but keeping backwards compatability just in case)
@carlio carlio requested a review from chocoelho July 8, 2020 15:00
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 80.508% when pulling 4a2b4c7 on bugfix/389-vulture-compatability into e6bb8a3 on develop.

Copy link
Contributor

@chocoelho chocoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty neat @carlio, I'm just missing a case testcase such as the one found in vulture readme:

import os

class Greeter:
    def greet(self):
        print("Hi")

def hello_world():
    message = "Hello, world!"
    greeter = Greeter()
    greet_func = getattr(greeter, "greet")
    greet_func()

if __name__ == "__main__":
    hello_world()

How do you feel about adding it? You can check the tests under tests/tools/bandit, or any other tool in the dirname path, for some ideas on how to approach that.

@chocoelho chocoelho merged commit aa0cd3f into develop Aug 22, 2020
@chocoelho chocoelho deleted the bugfix/389-vulture-compatability branch August 22, 2020 15:14
@chocoelho
Copy link
Contributor

@carlio I'm merging this to release a new patch.
Later on, I'll be adding the test case just to make sure we can detect earlier issues like this.

@chocoelho chocoelho mentioned this pull request Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants