should produce error for attribute hidden by a method

[proofit404]

How to reproduce

$ flake8 --version
6.0.0 (mccabe: 0.7.0, pycodestyle: 2.10.0, pyflakes: 3.0.1) CPython 3.11.1 on Linux
$ flake8 ok.py
ok.py:5:5: F811 redefinition of unused 'bar' from line 2
$ flake8 fail.py

ok.py

class Foo:
    def bar(self):
        return 0

    def bar(self):
        return 1

fail.py

class Foo:
    bar = 0

    def bar(self):
        return 1

Reasons

I do understand that redefinition of variables is a useful pattern, for example structlog Bound Loggers uses it extensively.

log = structlog.get_logger()
log = log.bind(user=user)
log = log.bind(time=now())
log.info('hello world')

Problems

I spent some time debugging a problem in our code base related to Factory Boy Lazy Attributes.

class UserFactory(Factory):
    class Meta:
        model = User

    name = 'joe'
    email = LazyAttribute(lambda user: f'{user.name}@example.com')

    # A 1000 lines later

    @post_generation
    def email(self):
        return 'fake@stub.io'

Proposal

Deny attribute redefinition inside class body.

Thoughts?

[asottile]

a function overriding a variable is almost always an error -- if you want to do exceptional things you can utilize # noqa (you're already using flake8)

[asottile]

note that your example under "reasons" is unrelated and works fine

[proofit404]

@asottile thanks for the response!

I explained myself in a wrong way.

I expected flake8 fail.py to report F811 as well.

I.e. I don't need to disable existed error, I want more strict rule.

[asottile]

ah ok the title misled me -- I've updated it

[asottile]

try out #761 ?