-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New AES-256 encryption #872
Conversation
fix annotation encryption
Nice addition, thank you @andersonhc! Pylint is complaining on a few points:
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #872 +/- ##
==========================================
- Coverage 93.39% 93.22% -0.17%
==========================================
Files 27 27
Lines 7388 7679 +291
Branches 1333 1395 +62
==========================================
+ Hits 6900 7159 +259
- Misses 307 328 +21
- Partials 181 192 +11
☔ View full report in Codecov by Sentry. |
OK, there is just a remaining question about a potential extra unit test. I let you tell me if you think it's useless, or add it to the PR, |
Merged! Thank you @andersonhc 👍 |
This PR is implementing a new encryption method - AES 256.
AES 256 was introduced in PDF 2.0. The new algorithm got rid of all weak hashes, specially MD5, making the new method much stronger than all the old methods.
This PR is also fixing encryption of annotation strings.
The documentation was updated and the new test should cover all the changes.
Checklist:
The GitHub pipeline is OK (green),
meaning that both
pylint
(static code analyzer) andblack
(code formatter) are happy with the changes of this PR.A unit test is covering the code added / modified by this PR
This PR is ready to be merged
In case of a new feature, docstrings have been added, with also some documentation in the
docs/
folderA mention of the change is present in
CHANGELOG.md
By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.