Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build matrix for wheels? #2411

Closed
trim21 opened this issue Dec 23, 2024 · 3 comments
Closed

build matrix for wheels? #2411

trim21 opened this issue Dec 23, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@trim21
Copy link
Contributor

trim21 commented Dec 23, 2024

I'm updating ci build from opendal and we release cp310-manylinux,cp311-abi3,cp313-cp313t-manylinux wheels.

cp310-manylinux and cp313-cp313t-manylinux can be conbined as build -o dist -i python3.10 -i python3.13t, but abi3 feature is enabled with --features=abi3 make it must exists in a seprated command, and therefore make it build whole project twice.

Is there any possible to make then unified?

for example:

[[tool.matruin.matrix]]
interpreter = '3.10'

[[tool.matruin.matrix]]
interpreter = '3.13t'

[[tool.matruin.matrix]]
interpreter = '3.11'
features = ['abi3']
@trim21 trim21 added the enhancement New feature or request label Dec 23, 2024
@trim21 trim21 changed the title build matrix from args? build matrix for wheels? Dec 23, 2024
@messense
Copy link
Member

Duplicate of PyO3/maturin-action#166

The abi3 issue is a known bug of pyo3: #2385

@messense messense closed this as not planned Won't fix, can't repro, duplicate, stale Dec 24, 2024
@trim21
Copy link
Contributor Author

trim21 commented Dec 24, 2024

The abi3 issue is a known bug of pyo3: #2385

what abi3 issue are you referring to?

@messense
Copy link
Member

abi3 feature is enabled with --features=abi3 make it must exists in a seprated command

abi3 feature should be able to coexist with other arguments, even when abi3 feature is enable, pyo3 will not make use of it: PyO3/pyo3#4733, but it currently does not work well with generate-import-lib feature yet, which is #2385 (it's not transfered to pyo3/pyo3 because people will mostly likely lookup maturin issue tracker first for such kind of issues).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants