-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to reduce central heating supply temperatures annually (defaults to 1%/a) #1290
Conversation
for more information, see https://pre-commit.ci
…to annual-temperature-reduction
for more information, see https://pre-commit.ci
Validator ReportI am the Validator. Download all artifacts here. ❗ Run failed!Download 'logs' artifact to see more details.
Model Metrics Comparing |
for more information, see https://pre-commit.ci
…to annual-temperature-reduction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Some code suggestions:
Required config setting for transmission efficiency related to #963 |
Co-authored-by: Fabian Neumann <fabian.neumann@outlook.de>
Co-authored-by: Fabian Neumann <fabian.neumann@outlook.de>
Co-authored-by: Fabian Neumann <fabian.neumann@outlook.de>
@fneum thanks for the review! Addressed all comments but one (see above). Happy to make the changes, I'm fine either way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Can merge once at least ubuntu test passes (in case I miss to do it).
PR #1264 updated central heating temperatures to current values based on data.
Previously, temperatures were guesstimated compromises between current and future temperatures.
This PR adds the option of decreasing temperatures (forward and return) by a fixed annual percentage (1% by default).
Changes proposed in this Pull Request
build_central_heating_temperature_profiles
rule dependent onplanning_horizons
wildcard`build_central_heating_profiles.run
build_cop_profiles
planning_horizon
-dependentcop_profiles
inputplanning_horizon
-dependent forprepare_sector_network
, a)add_existing_baseyear
,add_brownfield
(solve_myopic
),add_existing_baseyear
/prepare_perfect_foresight
(solve_perfect
)update_heat_pump_efficiency()
function to myopic/perfect foresight mode to update heat pump efficiencies of existing heat pumps in preceding yearsChecklist
envs/environment.yaml
.config/config.default.yaml
.doc/configtables/*.csv
.doc/data_sources.rst
.doc/release_notes.rst
is added.Testing
This config was used:
Note: testing with perfect foresight requires deactivating the following lines in
config.default
:Average forward temperatures in selected countries, with different foresight options:
Average COP: