Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to reduce central heating supply temperatures annually (defaults to 1%/a) #1290

Merged
merged 29 commits into from
Oct 10, 2024

Conversation

amos-schledorn
Copy link
Contributor

@amos-schledorn amos-schledorn commented Sep 12, 2024

PR #1264 updated central heating temperatures to current values based on data.
Previously, temperatures were guesstimated compromises between current and future temperatures.
This PR adds the option of decreasing temperatures (forward and return) by a fixed annual percentage (1% by default).

Changes proposed in this Pull Request

  • Make build_central_heating_temperature_profiles rule dependent on planning_horizons wildcard`
  • Add exponential temperature decay to build_central_heating_profiles.run
  • Make build_cop_profiles planning_horizon-dependent
  • Make cop_profiles input planning_horizon-dependent for prepare_sector_network, a) add_existing_baseyear, add_brownfield (solve_myopic), add_existing_baseyear/prepare_perfect_foresight (solve_perfect)
  • Add update_heat_pump_efficiency() function to myopic/perfect foresight mode to update heat pump efficiencies of existing heat pumps in preceding years

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.

Testing

This config was used:

scenario:
  clusters:
  - 39
  planning_horizons:
  - 2030
  - 2040

countries: ['AL', 'AT', 'BA', 'BE', 'BG', 'CH', 'CZ', 'DE', 'DK', 'EE', 'ES', 'FI', 'FR', 'GB', 'GR', 'HR', 'HU', 'IE', 'IT', 'LT', 'LU', 'LV', 'ME', 'MK', 'NL', 'NO', 'PL', 'PT', 'RO', 'RS', 'SE', 'SI', 'SK', 'XK']

clustering:
  temporal:
    resolution_sector: 168h

Note: testing with perfect foresight requires deactivating the following lines in config.default:

sector:
    DC:
      efficiency_static: 0.98
      efficiency_per_1000km: 0.977

Average forward temperatures in selected countries, with different foresight options:
image

Average COP:
image

@amos-schledorn amos-schledorn marked this pull request as draft September 12, 2024 15:43
@amos-schledorn amos-schledorn changed the title Annual temperature reduction Add option to reduce central heating supply temperatures annually (defaults to 1%/a) Sep 12, 2024
Copy link
Contributor

github-actions bot commented Sep 17, 2024

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

❗ Run failed!

Download 'logs' artifact to see more details.

  • master failed in: build_transmission_projects
  • annual-temperature-reduction passed! ✅

Model Metrics

Benchmarks Image not available Image not available Image not available

Comparing annual-temperature-reduction (2e6132c) with master (6dd41b8).
Branch is 29 commits ahead and 2 commits behind.
Last updated on 2024-10-10 09:17:43 CEST.

@amos-schledorn amos-schledorn marked this pull request as ready for review September 17, 2024 15:47
Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some code suggestions:

doc/release_notes.rst Outdated Show resolved Hide resolved
scripts/add_brownfield.py Outdated Show resolved Hide resolved
scripts/build_central_heating_temperature_profiles/run.py Outdated Show resolved Hide resolved
scripts/build_central_heating_temperature_profiles/run.py Outdated Show resolved Hide resolved
scripts/build_central_heating_temperature_profiles/run.py Outdated Show resolved Hide resolved
scripts/prepare_perfect_foresight.py Show resolved Hide resolved
@fneum
Copy link
Member

fneum commented Sep 24, 2024

Required config setting for transmission efficiency related to #963

amos-schledorn and others added 3 commits September 30, 2024 10:42
Co-authored-by: Fabian Neumann <fabian.neumann@outlook.de>
Co-authored-by: Fabian Neumann <fabian.neumann@outlook.de>
Co-authored-by: Fabian Neumann <fabian.neumann@outlook.de>
@amos-schledorn
Copy link
Contributor Author

@fneum thanks for the review! Addressed all comments but one (see above). Happy to make the changes, I'm fine either way.

Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Can merge once at least ubuntu test passes (in case I miss to do it).

@amos-schledorn amos-schledorn merged commit 5402088 into master Oct 10, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants