This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 212
Data Pipeline V2: Refactor Deserializer into Serve Input #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaton
requested review from
ananyahjha93,
Borda,
carmocca,
ethanwharris,
justusschock and
kaushikb11
as code owners
December 1, 2021 09:14
Codecov Report
@@ Coverage Diff @@
## master #1013 +/- ##
==========================================
+ Coverage 85.28% 85.33% +0.05%
==========================================
Files 254 254
Lines 13655 13662 +7
==========================================
+ Hits 11645 11659 +14
+ Misses 2010 2003 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…github.com/PyTorchLightning/lightning-flash into issue_916_refactor_deserializer_into_input
ethanwharris
reviewed
Dec 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 😃 I guess the existing deserializers should be renamed to end in ServeInput
and will also need to extend serve input rather than deserializer
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #916
This change is temporary until we get merge the ServeInput and add
serve_load_sample
directly to the Input base class.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃