Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix ReduceLROnPlateau #1251

Merged
merged 5 commits into from
Mar 28, 2022
Merged

Fix ReduceLROnPlateau #1251

merged 5 commits into from
Mar 28, 2022

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Mar 25, 2022

What does this PR do?

Fixes #1244

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@ethanwharris ethanwharris added the bug / fix Something isn't working label Mar 25, 2022
@ethanwharris ethanwharris added this to the 0.7.x milestone Mar 25, 2022
@ethanwharris ethanwharris changed the title Fix LR Schedulers Fix ReduceLROnPlateau Mar 25, 2022
@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #1251 (f802d8e) into master (64e7589) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1251      +/-   ##
==========================================
- Coverage   91.19%   91.18%   -0.01%     
==========================================
  Files         286      286              
  Lines       12793    12791       -2     
==========================================
- Hits        11666    11663       -3     
- Misses       1127     1128       +1     
Flag Coverage Δ
unittests 91.18% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/model.py 87.71% <ø> (-0.07%) ⬇️
flash/text/question_answering/model.py 91.89% <0.00%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64e7589...f802d8e. Read the comment docs.

Copy link
Contributor

@krshrimali krshrimali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice doctests! Thanks for the fix, @ethanwharris 🚀 LGTM!

@ethanwharris ethanwharris merged commit a59e10a into master Mar 28, 2022
@ethanwharris ethanwharris deleted the bugfix/lr_schedulers branch March 28, 2022 19:05
ethanwharris added a commit that referenced this pull request Mar 30, 2022
ethanwharris added a commit that referenced this pull request Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use ReduceLROnPlateau in ObjectDetector
2 participants