Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add support for all image classifier backbones to the image embedder #1264

Merged
merged 15 commits into from
Apr 6, 2022

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Mar 30, 2022

What does this PR do?

Part of #1031

Breaking changes

  • Removes the dino strategy (used to work only on GPU)
  • Removes the MOCO strategy (wasn't working anyway)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@ethanwharris ethanwharris added the enhancement New feature or request label Mar 30, 2022
@ethanwharris ethanwharris added this to the 0.8.0 milestone Mar 30, 2022
@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #1264 (a0b518a) into master (df67f87) will decrease coverage by 1.53%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1264      +/-   ##
==========================================
- Coverage   91.19%   89.65%   -1.54%     
==========================================
  Files         286      284       -2     
  Lines       12791    12745      -46     
==========================================
- Hits        11665    11427     -238     
- Misses       1126     1318     +192     
Flag Coverage Δ
unittests 89.65% <100.00%> (-1.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lash/image/embedding/vissl/transforms/multicrop.py 98.11% <ø> (ø)
...lash/image/embedding/vissl/transforms/utilities.py 100.00% <ø> (+17.07%) ⬆️
flash/image/embedding/heads/vissl_heads.py 100.00% <100.00%> (ø)
flash/image/embedding/losses/vissl_losses.py 100.00% <100.00%> (ø)
flash/image/embedding/model.py 98.38% <100.00%> (+0.34%) ⬆️
...ash/image/embedding/strategies/vissl_strategies.py 100.00% <100.00%> (ø)
...ash/image/embedding/transforms/vissl_transforms.py 100.00% <100.00%> (ø)
flash/image/embedding/vissl/adapter.py 93.75% <100.00%> (+1.35%) ⬆️
flash/image/embedding/vissl/transforms/__init__.py 100.00% <100.00%> (ø)
flash/text/classification/input.py 53.33% <0.00%> (-46.67%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df67f87...a0b518a. Read the comment docs.

@ethanwharris ethanwharris merged commit 3c74081 into master Apr 6, 2022
@ethanwharris ethanwharris deleted the feature/ssl_backbones branch April 6, 2022 11:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant