Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

added Normalization transformation to per_sample transforms #1399

Conversation

Nico995
Copy link
Contributor

@Nico995 Nico995 commented Jul 19, 2022

What does this PR do?

Adds the ability to normalize input data in SemanticSegmentationData module.

Fixes #1398

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #1399 (bb9b383) into master (04f1b8f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head bb9b383 differs from pull request most recent head 327fec9. Consider uploading reports for the commit 327fec9 to get more accurate results

@@           Coverage Diff           @@
##           master    #1399   +/-   ##
=======================================
  Coverage   92.92%   92.92%           
=======================================
  Files         286      286           
  Lines       12835    12837    +2     
=======================================
+ Hits        11927    11929    +2     
  Misses        908      908           
Flag Coverage Δ
unittests 92.92% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/image/segmentation/input_transform.py 94.11% <100.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04f1b8f...327fec9. Read the comment docs.

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!! LGTM 😃

@mergify mergify bot removed the has conflicts label Jul 20, 2022
@ethanwharris ethanwharris merged commit 4f6fe93 into Lightning-Universe:master Jul 20, 2022
@Nico995 Nico995 deleted the enhancement/1398_semseg_data_norm branch July 20, 2022 09:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable input normalization in SemanticSegmentationData module
2 participants