This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
[refactor] DataPipeline 1/n #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaton
requested review from
Borda,
carmocca,
justusschock,
kaushikb11 and
teddykoker
as code owners
|
Hello @tchaton! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-03-25 19:32:55 UTC |
kaushikb11
reviewed
Mar 22, 2021
kaushikb11
reviewed
Mar 22, 2021
kaushikb11
reviewed
Mar 22, 2021
kaushikb11
reviewed
Mar 22, 2021
kaushikb11
reviewed
Mar 22, 2021
kaushikb11
reviewed
Mar 22, 2021
kaushikb11
reviewed
Mar 22, 2021
kaushikb11
reviewed
Mar 22, 2021
kaushikb11
reviewed
Mar 22, 2021
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
…ng/lightning-flash into data_pipeline_1_n
kaushikb11
reviewed
Mar 22, 2021
kaushikb11
reviewed
Mar 22, 2021
edgarriba
approved these changes
Mar 25, 2021
kaushikb11
approved these changes
Mar 25, 2021
|
LGTM Let's meger it |
Borda
reviewed
Mar 25, 2021
carmocca
approved these changes
Mar 25, 2021
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Borda
approved these changes
Mar 25, 2021
tests/data/test_data_pipeline.py
Outdated
Comment on lines
626
to
638
| # assert preprocess.train_load_data_called | ||
| # assert preprocess.train_per_sample_pre_tensor_transform_called | ||
| # assert preprocess.train_collate_called | ||
| assert preprocess.train_per_batch_transform_on_device_called | ||
| # assert preprocess.val_load_data_called | ||
| # assert preprocess.val_load_sample_called | ||
| # assert preprocess.val_per_sample_to_tensor_transform_called | ||
| # assert preprocess.val_collate_called | ||
| assert preprocess.val_per_batch_transform_on_device_called | ||
| # assert preprocess.test_load_data_called | ||
| # assert preprocess.test_per_sample_to_tensor_transform_called | ||
| # assert preprocess.test_per_sample_post_tensor_transform_called | ||
| # assert preprocess.predict_load_data_called |
There was a problem hiding this comment.
if you do not use these assets, remove them
There was a problem hiding this comment.
Not, it is related to the previous bug. Just a reminder on how to update the test.
edenlightning
approved these changes
Mar 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds DataPipeline without any changes to the model.
However, as the model need to be changed, it will be done as a hard switch and the following PRs will contain all tasks at once.