Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Serve sanity checks #423

Merged
merged 22 commits into from
Jun 18, 2021
Merged

Serve sanity checks #423

merged 22 commits into from
Jun 18, 2021

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Jun 17, 2021

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #423 (7aa3835) into master (089c4e8) will increase coverage by 1.34%.
The diff coverage is 94.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #423      +/-   ##
==========================================
+ Coverage   89.97%   91.31%   +1.34%     
==========================================
  Files         112      112              
  Lines        7003     7060      +57     
==========================================
+ Hits         6301     6447     +146     
+ Misses        702      613      -89     
Flag Coverage Δ
unittests 91.31% <94.96%> (+1.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/utilities/imports.py 90.90% <ø> (ø)
flash/core/data/data_pipeline.py 94.37% <66.66%> (+0.39%) ⬆️
flash/core/trainer.py 87.20% <85.71%> (-0.45%) ⬇️
flash/core/model.py 84.80% <88.23%> (+6.49%) ⬆️
flash/core/serve/flash_components.py 88.52% <96.29%> (+38.52%) ⬆️
flash/__init__.py 89.47% <100.00%> (+0.58%) ⬆️
flash/core/classification.py 96.47% <100.00%> (+2.81%) ⬆️
flash/core/data/process.py 85.84% <100.00%> (+0.63%) ⬆️
flash/image/classification/data.py 94.18% <100.00%> (+4.18%) ⬆️
flash/image/classification/model.py 86.36% <100.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 089c4e8...7aa3835. Read the comment docs.

@@ -115,7 +120,8 @@ jobs:

- name: Tests
env:
FIFTYONE_DO_NOT_TRACK: true
FLASH_TEST_TOPIC: ${{ matrix.topic }}
FIFTYONE_DO_NOT_TRACK: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall t be rather just 0/1?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it can be. This was done by the fiftyone people for something on their end. I wouldn't want to change it in case something breaks.

flash/core/data/process.py Outdated Show resolved Hide resolved
comp = FlashServeModelComponent(self)
composition = Composition(predict=comp)
composition = Composition(predict=comp, TESTING=os.environ["FLASH_TESTING"] == "1")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, some variables are 0/1 other you write s true... lets be consistent

@ethanwharris ethanwharris added this to the 0.4 milestone Jun 17, 2021
flash/core/classification.py Outdated Show resolved Hide resolved
flash/core/classification.py Outdated Show resolved Hide resolved
flash/core/utilities/imports.py Outdated Show resolved Hide resolved
ethanwharris and others added 5 commits June 18, 2021 08:04
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ! Know we can add an extra sanity call to the Trainer.

flash/core/model.py Outdated Show resolved Hide resolved
flash/core/model.py Outdated Show resolved Hide resolved
ethanwharris and others added 2 commits June 18, 2021 08:58
Co-authored-by: thomas chaton <thomas@grid.ai>
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@tchaton tchaton merged commit b8a0820 into master Jun 18, 2021
@tchaton tchaton deleted the feature/serve_sanity branch June 18, 2021 13:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants