-
Notifications
You must be signed in to change notification settings - Fork 212
Conversation
Codecov Report
@@ Coverage Diff @@
## master #423 +/- ##
==========================================
+ Coverage 89.97% 91.31% +1.34%
==========================================
Files 112 112
Lines 7003 7060 +57
==========================================
+ Hits 6301 6447 +146
+ Misses 702 613 -89
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@@ -115,7 +120,8 @@ jobs: | |||
|
|||
- name: Tests | |||
env: | |||
FIFTYONE_DO_NOT_TRACK: true | |||
FLASH_TEST_TOPIC: ${{ matrix.topic }} | |||
FIFTYONE_DO_NOT_TRACK: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall t be rather just 0/1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it can be. This was done by the fiftyone people for something on their end. I wouldn't want to change it in case something breaks.
flash/core/model.py
Outdated
comp = FlashServeModelComponent(self) | ||
composition = Composition(predict=comp) | ||
composition = Composition(predict=comp, TESTING=os.environ["FLASH_TESTING"] == "1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, some variables are 0/1 other you write s true... lets be consistent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great ! Know we can add an extra sanity call to the Trainer.
Co-authored-by: thomas chaton <thomas@grid.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
What does this PR do?
Fixes # (issue)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃