Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add prediction unwrapping and serialization for icevision tasks #727

Merged
merged 9 commits into from
Sep 3, 2021

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Sep 3, 2021

What does this PR do?

Fixes #639

Screenshot 2021-09-03 at 19 42 43

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #727 (db70df5) into master (4ebc45d) will decrease coverage by 0.02%.
The diff coverage is 81.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #727      +/-   ##
==========================================
- Coverage   89.38%   89.36%   -0.03%     
==========================================
  Files         197      198       +1     
  Lines       10517    10538      +21     
==========================================
+ Hits         9401     9417      +16     
- Misses       1116     1121       +5     
Flag Coverage Δ
unittests 89.36% <81.52%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/pointcloud/detection/open3d_ml/app.py 26.59% <ø> (-0.78%) ⬇️
flash/pointcloud/segmentation/open3d_ml/app.py 33.33% <ø> (ø)
flash/core/integrations/icevision/data.py 86.27% <68.18%> (-9.56%) ⬇️
flash/core/integrations/icevision/transforms.py 72.50% <77.50%> (+3.05%) ⬆️
flash/core/integrations/icevision/adapter.py 93.05% <87.50%> (+0.09%) ⬆️
flash/core/data/batch.py 95.93% <100.00%> (-0.59%) ⬇️
flash/core/data/serialization.py 100.00% <100.00%> (ø)
flash/image/detection/data.py 93.75% <100.00%> (ø)
flash/image/detection/model.py 100.00% <100.00%> (ø)
flash/image/detection/serialization.py 93.87% <100.00%> (+3.49%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ebc45d...db70df5. Read the comment docs.

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome !

CHANGELOG.md Outdated Show resolved Hide resolved
flash/core/integrations/icevision/transforms.py Outdated Show resolved Hide resolved
ethanwharris and others added 3 commits September 3, 2021 20:34
@ethanwharris ethanwharris merged commit 7cf77c7 into master Sep 3, 2021
@ethanwharris ethanwharris deleted the feature/icevision_unpack_predictions branch September 3, 2021 21:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ObjDetection: make the prediction intuative
3 participants