Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fixed a bug where validation metrics could be aggregated together with test metrics #900

Merged
merged 3 commits into from
Oct 29, 2021

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Oct 29, 2021

What does this PR do?

Fixes #843

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #900 (9c3257a) into master (194c8d9) will increase coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head 9c3257a differs from pull request most recent head 136a476. Consider uploading reports for the commit 136a476 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #900      +/-   ##
==========================================
+ Coverage   89.01%   89.08%   +0.07%     
==========================================
  Files         230      230              
  Lines       12719    12709      -10     
==========================================
  Hits        11322    11322              
+ Misses       1397     1387      -10     
Flag Coverage Δ
unittests 89.08% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/model.py 88.20% <100.00%> (+0.02%) ⬆️
...ash/image/classification/integrations/baal/data.py 40.20% <0.00%> (-1.29%) ⬇️
...ash/image/classification/integrations/baal/loop.py 35.55% <0.00%> (+3.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 194c8d9...136a476. Read the comment docs.

@ethanwharris ethanwharris merged commit ddd4c94 into master Oct 29, 2021
@ethanwharris ethanwharris deleted the bugfix/test_metrics branch October 29, 2021 15:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The test step should not use the same metrics objects as validation
2 participants