-
Notifications
You must be signed in to change notification settings - Fork 212
Conversation
Codecov Report
@@ Coverage Diff @@
## master #933 +/- ##
==========================================
- Coverage 89.00% 88.47% -0.54%
==========================================
Files 238 239 +1
Lines 12917 12961 +44
==========================================
- Hits 11497 11467 -30
- Misses 1420 1494 +74
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Healthy cleaning 👍
if TYPE_CHECKING: | ||
from flash.core.model import Task | ||
|
||
|
||
class DataLoaderGetter: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still wraps and patches the dataloader, right? Is there no way around this?
Will this patch be assigned to back to the loader or just used internally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, unfortunately this was the only solution for now, but the upcoming data pipeline refactor should remove this patching entirely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dawn ... This is quite painful .
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
…rchLightning/lightning-flash into bugfix/pl_1.5_compatibility
What does this PR do?
Fixes # (issue)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃