Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Support PL 1.5.0 #933

Merged
merged 17 commits into from
Nov 5, 2021
Merged

Support PL 1.5.0 #933

merged 17 commits into from
Nov 5, 2021

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Nov 4, 2021

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #933 (0c170fb) into master (642e63f) will decrease coverage by 0.53%.
The diff coverage is 84.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #933      +/-   ##
==========================================
- Coverage   89.00%   88.47%   -0.54%     
==========================================
  Files         238      239       +1     
  Lines       12917    12961      +44     
==========================================
- Hits        11497    11467      -30     
- Misses       1420     1494      +74     
Flag Coverage Δ
unittests 88.47% <84.93%> (-0.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ash/image/classification/integrations/baal/loop.py 33.33% <41.17%> (+1.60%) ⬆️
flash/image/classification/adapters.py 82.58% <87.50%> (+0.56%) ⬆️
flash/core/data/data_pipeline.py 95.66% <100.00%> (+0.55%) ⬆️
flash/core/data/new_data_module.py 88.00% <100.00%> (+0.40%) ⬆️
flash/core/trainer.py 88.72% <100.00%> (+4.59%) ⬆️
flash/core/utilities/compatibility.py 100.00% <100.00%> (ø)
flash/core/utilities/imports.py 91.04% <100.00%> (+0.06%) ⬆️
flash/image/embedding/vissl/hooks.py 87.50% <100.00%> (+0.22%) ⬆️
flash/video/classification/model.py 86.74% <100.00%> (+0.16%) ⬆️
...age/face_detection/backbones/fastface_backbones.py 42.10% <0.00%> (-57.90%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 642e63f...0c170fb. Read the comment docs.

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Healthy cleaning 👍

flash/core/data/data_pipeline.py Outdated Show resolved Hide resolved
flash/core/trainer.py Outdated Show resolved Hide resolved
if TYPE_CHECKING:
from flash.core.model import Task


class DataLoaderGetter:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still wraps and patches the dataloader, right? Is there no way around this?
Will this patch be assigned to back to the loader or just used internally?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, unfortunately this was the only solution for now, but the upcoming data pipeline refactor should remove this patching entirely

flash/image/classification/adapters.py Outdated Show resolved Hide resolved
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dawn ... This is quite painful .

flash/core/trainer.py Outdated Show resolved Hide resolved
@ethanwharris ethanwharris added the bug / fix Something isn't working label Nov 5, 2021
@ethanwharris ethanwharris merged commit d0adc61 into master Nov 5, 2021
@ethanwharris ethanwharris deleted the bugfix/pl_1.5_compatibility branch November 5, 2021 12:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants