Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying the type of redirect for append_slash=True #1609

Closed
dstufft opened this issue Mar 15, 2015 · 3 comments · Fixed by #1610
Closed

Allow specifying the type of redirect for append_slash=True #1609

dstufft opened this issue Mar 15, 2015 · 3 comments · Fixed by #1610

Comments

@dstufft
Copy link
Contributor

dstufft commented Mar 15, 2015

It would be great to allow specifying the type of redirect to be used when using the append_slash parameter to notfound_view_config. Maybe the API could be append_slash=True gives you the current behavior, and append_slash=HTTPMovedPermanently for instance could be used to use HTTPMovedPermanently to do the redirect?
@mcdonc
Copy link
Member

mcdonc commented Mar 15, 2015

I'd be fine with that personally. Do you think you could provide a PR with the impl and tests Donald?

@dstufft
Copy link
Contributor Author

dstufft commented Mar 15, 2015

Yup, just wanted to see if there was any interest before I did :)

@dstufft dstufft mentioned this issue Mar 15, 2015
Merged
@dstufft
Copy link
Contributor Author

dstufft commented Mar 15, 2015

Okay, implemented in #1610.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow passing in a custom IResponse implementor for append_slash dstufft/pyramid
2 participants
@mcdonc @dstufft