Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow InstancePropertyHelper to accept properties with names on Python 3.13+ #3762

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hroncok
Copy link

@hroncok hroncok commented Jun 17, 2024

Fixes #3761

@mmerickel
Copy link
Member

We don't currently have 3.13 in the test suite so I can't trust the cicd here. Perhaps you could add the config for that to this PR and focus it on getting Pyramid working in 3.13?

As a side note, isn't cgi removed in 3.13 such that webob doesn't work on 3.13 so you're hosed anyway until we fix that?

@hroncok
Copy link
Author

hroncok commented Jun 19, 2024

Perhaps you could add the config for that to this PR and focus it on getting Pyramid working in 3.13?

I can try, but no promises.

As a side note, isn't cgi removed in 3.13 such that webob doesn't work on 3.13 so you're hosed anyway until we fix that?

I use legacy-cgi for that.

@hroncok
Copy link
Author

hroncok commented Jun 19, 2024

The updated tox config works locally. Hopefully, it also works on the CI (needs your approval).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_util fails with Python 3.13
2 participants