Fix #113 #357
Fix #113 #357
Conversation
|
Would you be comfortable adding a unit test for this? |
|
Sure, just give me a few moments. Do you know what's going on with this project? There haven't been any updates in a while. |
|
Thanks! I spoke with @edschofield yesterday and I'm going to help him maintain python-future going forward. We're using it heavily at Pinterest at the moment and we have a few bugs we've discovered and patches we'd like to share upstream :) |
|
Perfect! Thank you so much :) |
|
Oh, sorry, I should have marked it WIP! I noticed that a couple of the other tests failed with this change, and I haven't figured out why yet. Can you please revert this? |
|
Can you please take a look at #361? It fixes the regression that this PR introduced, and is a 1-line change. |
|
Will do, thanks. I assumed the test failures were a result of the known issues with 3.5+, but that was clearly in error. Great eye :) |
No description provided.