Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uninitialized value M in DMCBatched::setMultiplicities #2243

Closed
ye-luo opened this issue Jan 24, 2020 · 1 comment · Fixed by #2244
Closed

Uninitialized value M in DMCBatched::setMultiplicities #2243

ye-luo opened this issue Jan 24, 2020 · 1 comment · Fixed by #2244
Assignees
@PDoakORNL

Comments

@ye-luo
Copy link
Contributor

ye-luo commented Jan 24, 2020

GCC warning detects this in #2232
The original code in QMCUpdateBase::setMultiplicity sets M = walker.Weight.
DMCBatched::setMultiplicities is not doing the same way.
Please explain the change and fix the warning as well.
@ye-luo ye-luo mentioned this issue Jan 24, 2020
Merged
@PDoakORNL
Copy link
Contributor

PDoakORNL commented Jan 24, 2020 •
edited
Loading

Nice catch, Clang let me down here, it doesn't warn and its wrong

@PDoakORNL PDoakORNL mentioned this issue Jan 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PDoakORNL PDoakORNL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Working Population Control for DMCBatched driver PDoakORNL/qmcpack
2 participants
@ye-luo @PDoakORNL