Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meaningful test of ppconvert in cmake #2929

Closed
correaa opened this issue Feb 17, 2021 · 0 comments · Fixed by #3004
Closed

Add meaningful test of ppconvert in cmake #2929

correaa opened this issue Feb 17, 2021 · 0 comments · Fixed by #3004

Comments

@correaa
Copy link
Contributor

correaa commented Feb 17, 2021

@markdewing @prckent

Please add numdiff -a 0.0001 ../build/src/QMCTools/ppconvert/test/Oxygen/O.BFD.xml ../tests/solids/monoO_1x1x1_pp/O.BFD.xml or equivalent to the tests, (with dependency or as part of ppconvert_does_not_crash). I don't know how to do this.

Is your feature request related to a problem? Please describe.
This complements ppconvert_does_not_crash. Comparing with a gold file (O.BFD.xml) is the only meaningful test of `ppconvert.
Currently it is only tested manually.

Describe the solution you'd like

Add to ctest, and also consider making -DBUILD_PPCONVERT=1 the default for cmake (if not already).

Describe alternatives you've considered

Running commands manually

Additional context

This is part of the refactoring of ppconvert to get rid of Blitz.
Some first steps towards this was done here: #2904

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant