Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qmc-fit doesn't have a clean help option #4479

Closed
ye-luo opened this issue Feb 23, 2023 · 1 comment · Fixed by #4475
Closed

qmc-fit doesn't have a clean help option #4479

ye-luo opened this issue Feb 23, 2023 · 1 comment · Fixed by #4475

Comments

@ye-luo
Copy link
Contributor

ye-luo commented Feb 23, 2023

Describe the bug
-h

$ qmc-fit -h

  error:
    unknown fit type: -h
    valid options are: ['ts', 'u']
  exiting.

  File "/home/yeluo/opt/qmcpack/nexus/bin/qmc-fit", line 559, in <module>
    error('unknown fit type: {0}\nvalid options are: {1}'.format(fit_type,fit_types))
  File "/home/yeluo/opt/qmcpack/nexus/lib/generic.py", line 138, in error
    traceback.print_stack()

--help

$ qmc-fit --help

  error:
    unknown fit type: --help
    valid options are: ['ts', 'u']
  exiting.

  File "/home/yeluo/opt/qmcpack/nexus/bin/qmc-fit", line 559, in <module>
    error('unknown fit type: {0}\nvalid options are: {1}'.format(fit_type,fit_types))
  File "/home/yeluo/opt/qmcpack/nexus/lib/generic.py", line 138, in error
    traceback.print_stack()

It would be better to have a nice help output

@prckent
Copy link
Contributor

prckent commented Feb 23, 2023

Good point

--help should be implemented for consistency with qmca

Since qmc-fit uses OptionParser like qmca, adding --help should be quick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants