Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convertion options for file format work after deselectin whole converter (Linux, 0.1.9, x64) #38

Closed
miniworm opened this issue Nov 26, 2015 · 3 comments
Labels
Milestone

Comments

@miniworm
Copy link

I've selected to convert subtitles to SRT format. Then I've disabled converter so everything on converter tab is grayed-out and disabled. In this case charset conversion is really disabled but format conversion still works - final files are in SRt format regardless of original format.

@krzemin krzemin added the bug label Nov 26, 2015
@krzemin krzemin added this to the 0.2.1 milestone Nov 26, 2015
@krzemin
Copy link
Member

krzemin commented Nov 26, 2015

Well, I can partially confirm this bug. Actual format conversion doesn't take place, but file extension is changed according to grayed-out option, but shouldn't.

@miniworm
Copy link
Author

So it's even worst - extension changes with wrong format inside.

IMHO there should be 2 independent switches - on/off for charset conversion and on/off for format conversion.

@krzemin
Copy link
Member

krzemin commented Nov 26, 2015

I fixed it by not touching the extension when post-processing is not enabled.

In fact, there are independent switches for encoding/format/extension conversion, but they are controlled by "global" post-processing switch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants