Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opened DMG has application misaligned. #127

Open
hobleyd opened this issue Jun 14, 2023 · 5 comments · May be fixed by #128
Open

Opened DMG has application misaligned. #127

hobleyd opened this issue Jun 14, 2023 · 5 comments · May be fixed by #128

Comments

@hobleyd
Copy link

hobleyd commented Jun 14, 2023

image

When I create my DMG and open it, the icon is misaligned. How would I fix that, please?

- uses: QQxiaoming/create-dmg-action@v0.0.2
       with:
         name: 'shackleton'
         srcdir: 'build/macos/Build/Products/Release/shackleton.app'

(It's a Flutter app if that makes any difference. The image is in there, just way over to the right!

@fr3ak2402
Copy link

@hobleyd

I have a question, I would also like to use this action.

Does this action automatically upload the DMG, so that you can then also Downloaden in the area of the action?

@hobleyd
Copy link
Author

hobleyd commented Jul 30, 2023

     - uses: QQxiaoming/create-dmg-action@v0.0.2
       with:
         name: 'shackleton'
         srcdir: 'build/macos/Build/Products/Release/shackleton.app'
     # Upload generated dmg to the artifacts.
     - uses: actions/upload-artifact@v1
       with:
         name: shackleton.dmg
         path: shackleton.dmg

@fr3ak2402
Copy link

fr3ak2402 commented Jul 30, 2023

@hobleyd

Thank you, so if I understand correctly I do not have to specify a path from the DMG when uploading?

  - name: Create DMG
    uses: QQxiaoming/create-dmg-action@v0.0.2
    with:
      name: 'APP'
      srcdir: '${{ github.workspace }}/build_arm64/APP/APP.app'

  - name: Upload APP.dmg
    uses: actions/upload-artifact@v3
    with:
      name: APP.dmg
      path: APP.dmg

@hobleyd
Copy link
Author

hobleyd commented Jul 30, 2023

I certainly didn't need to.

@ctrlaltca
Copy link

In order for the icon to be placed correctly an additional parameter must be passed to create.dmg:

--icon Name.App 200 185

@Lethja Lethja linked a pull request Dec 8, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants