Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

Improve exception safety with smart pointers #27

Open
elfring opened this issue Jan 25, 2018 · 2 comments
Open

Improve exception safety with smart pointers #27

elfring opened this issue Jan 25, 2018 · 2 comments

Comments

@elfring
Copy link

elfring commented Jan 25, 2018

Would you like to wrap any pointer data members with the template class “std::unique_ptr”?

@CatKang
Copy link
Contributor

CatKang commented Jan 26, 2018

Thanks elfring,

But we prefer to use raw pointer than any smart pointers, and believe following good code style we can control it with no extra overhead.

Only once we used shared_ptr for Partition since we need it�s sharing of ownership and reference counting.

@elfring
Copy link
Author

elfring commented Jan 26, 2018

Did you notice that the implementation of the class “ZPMetaServer” is unsafe so far because of mentioned preferences?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants