-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use same BLAS implimentation as NumPy #18
Comments
There should be no problem, as long as it's faster than Apple's implementation. We should benchmark both and compare, we just haven't yet. The choice was more OpenBLAS vs Apple's. My preference was always OpenBLAS, but seems like on Mac, Apple's implementation is arguably faster, so we changed it despite of the fact that there seems to be some non-standard practices in the latter that cold lead to potential problems, or at least this is what other users of this library have been reported. |
My point is that NumPy is a requirement that already is built against a specific blas implimentation. The aer installer should automatically link against that. This gives me, for example, the intel mkl for free. This allows one to test against different blas and time them quite easily by simply changing numpy, for example using the —nomkl flag in conda. |
I see that there are versions of Numpy that are linked against OpenBLAS, depending on where Numpy comes from: Pypi -> OpenBlas , Conda -> mkl. |
With #543 merged, now we can chose which BAS implementation we want to build with. |
It is not clear to me wether qiskit_aer depends completely on numpy (or a set of external packages) or not.
|
What is the expected enhancement?
Currently, a BLAS implementation is needed Aer to build. However NumPy, which is a requirement, is already linked to a BLAS library. Under Anaconda, for example, this is the Intel MKL. It is possible to use this BLAS for Aer as well, a la Cython and the old
qasm_simulator
that used it.The text was updated successfully, but these errors were encountered: