Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No install target defined in cmake scripts #233

Closed
yurivict opened this issue Jun 11, 2019 · 5 comments
Closed

No install target defined in cmake scripts #233

yurivict opened this issue Jun 11, 2019 · 5 comments
Assignees
Labels
bug Something isn't working build system good first issue Good for newcomers

Comments

@yurivict
Copy link
Contributor

yurivict commented Jun 11, 2019

It does build the executable qasm_simulator.
It should also be installed. Does something else need to be installed too?

@yurivict yurivict added the bug Something isn't working label Jun 11, 2019
@atilag atilag added the good first issue Good for newcomers label Jun 26, 2019
@atilag
Copy link
Member

atilag commented Jun 26, 2019

Yep, depending on the OS we have to install BLAS and/or OpenMP libraries.
As this is not our main use-case (standalone executable), we haven't implemented the install target yet. But I'll put it in the backlog.
I can mentor too, if someone wants to jump in and implement it :)

@leskunberg
Copy link

I can implement it, but since this my first run at things I would appreciate some mentorship @atilag

@yurivict
Copy link
Contributor Author

yurivict commented Jul 8, 2019

You can just look at some other cmake project to see how installing files in done. For example, qTox: https://github.com/qTox/qTox

@leskunberg
Copy link

That gives me enough to run with. Thanks @yurivict

@atilag
Copy link
Member

atilag commented Oct 28, 2019

It's been a while, but maybe @leskunberg wants to resume this and try to add an install target for the standalone version? Otherwise, it's ok to close the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build system good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants