Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing unit tests, fail on deprecation warning qiskit/main #1097

Closed
2 tasks done
kt474 opened this issue Sep 20, 2023 · 3 comments · Fixed by #1099, #1102 or #1182
Closed
2 tasks done

Fix failing unit tests, fail on deprecation warning qiskit/main #1097

kt474 opened this issue Sep 20, 2023 · 3 comments · Fixed by #1099, #1102 or #1182
Assignees
Labels
bug Something isn't working
Milestone

Comments

@kt474
Copy link
Member

kt474 commented Sep 20, 2023

We run our unit tests on a nightly cron job again the main branch of qiskit (terra)

  • check/fix all failing tests
  • check/fix all deprecation warnings - we should also fail the test on deprecation warning

cc @1ucian0 @drew-distefano

@kt474 kt474 added the bug Something isn't working label Sep 20, 2023
@kt474
Copy link
Member Author

kt474 commented Sep 21, 2023

Reopening because 2 tests are still failing

One test failing

https://github.com/Qiskit/qiskit-ibm-runtime/actions/runs/6263642457/job/17008487156#step:5:839

test_coder_qc

NotImplementedError: This gate class <class 'qiskit.circuit.library.standard_gates.h.HGate'> does not support manually setting a condition on an instance. Instead you must set the label when instantiating a new object or via the .c_if() method

Update: this will be fixed by Qiskit/qiskit-ibm-provider#736

@kt474 kt474 reopened this Sep 21, 2023
@kt474 kt474 reopened this Sep 24, 2023
@1ucian0 1ucian0 added this to the 0.13.0 milestone Sep 26, 2023
@drew-distefano
Copy link
Collaborator

@kt474 please investigate (and implement?) alerts via slack or other method on failing tests so we don't have to manually check the results every day

@kt474 kt474 self-assigned this Oct 16, 2023
@kt474 kt474 removed this from the 0.13.0 milestone Oct 26, 2023
@drew-distefano drew-distefano changed the title Investigate/Fix failing unit tests again qiskit/main Fix failing unit tests, fail on deprecation warning qiskit/main Oct 27, 2023
@kt474
Copy link
Member Author

kt474 commented Oct 27, 2023

@kt474 please investigate (and implement?) alerts via slack or other method on failing tests so we don't have to manually check the results every day

Set up email alerts for failing tests, now just need to fail on deprecation warnings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants