From 8bf83b19db45c9b41f69c385355e9264ba6d2702 Mon Sep 17 00:00:00 2001 From: Akihiko Kuroda Date: Fri, 9 Feb 2024 15:29:06 -0500 Subject: [PATCH 1/3] take out unnecessary Job.save() Signed-off-by: Akihiko Kuroda --- gateway/api/services.py | 26 +++++++------------------- 1 file changed, 7 insertions(+), 19 deletions(-) diff --git a/gateway/api/services.py b/gateway/api/services.py index 9c9741983..d38797e6c 100644 --- a/gateway/api/services.py +++ b/gateway/api/services.py @@ -168,25 +168,13 @@ def save( Job instance """ - job = None - try: - job = Job( - program=program, - arguments=arguments, - author=author, - status=status, - config=jobconfig, - ) - job.save() - except (Exception) as save_job_exception: - logger.error( - "Exception was caught saving a Job. \n Error trace: %s", - save_job_exception, - ) - raise InternalServerErrorException( - "Unexpected error saving a job" - ) from save_job_exception - + job = Job( + program=program, + arguments=arguments, + author=author, + status=status, + config=jobconfig, + ) env = encrypt_env_vars(build_env_variables(token, job, json.dumps(arguments))) try: env["traceparent"] = carrier["traceparent"] From 11891d8422675cd2cb0a0805f23bed35068e5aef Mon Sep 17 00:00:00 2001 From: Akihiko Kuroda Date: Mon, 12 Feb 2024 09:11:35 -0500 Subject: [PATCH 2/3] review comment --- gateway/api/services.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gateway/api/services.py b/gateway/api/services.py index d38797e6c..ac14002c1 100644 --- a/gateway/api/services.py +++ b/gateway/api/services.py @@ -175,6 +175,8 @@ def save( status=status, config=jobconfig, ) + print("!!!!") + print(job.id) env = encrypt_env_vars(build_env_variables(token, job, json.dumps(arguments))) try: env["traceparent"] = carrier["traceparent"] @@ -186,7 +188,7 @@ def save( job.save() except (Exception) as save_job_exception: logger.error( - "Exception was caught saving the env_vars of the Job[%s]. \n Error trace: %s", + "Exception was caught saving the Job[%s]. \n Error trace: %s", job.id, save_job_exception, ) From 5fe6b64614dd6d1fe638b99f8d62b3f2408cf842 Mon Sep 17 00:00:00 2001 From: Akihiko Kuroda Date: Mon, 12 Feb 2024 09:22:54 -0500 Subject: [PATCH 3/3] review comment --- gateway/api/services.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/gateway/api/services.py b/gateway/api/services.py index ac14002c1..ced57d50b 100644 --- a/gateway/api/services.py +++ b/gateway/api/services.py @@ -175,8 +175,6 @@ def save( status=status, config=jobconfig, ) - print("!!!!") - print(job.id) env = encrypt_env_vars(build_env_variables(token, job, json.dumps(arguments))) try: env["traceparent"] = carrier["traceparent"]