Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add frequency collision analysis pass #8621

Closed
wants to merge 2 commits into from

Conversation

sitong1011
Copy link

@sitong1011 sitong1011 commented Aug 26, 2022

Summary

Add an analysis pass for detecting frequency collision based on the calibrations data provided by backends and the types of frequency collisions in the research paper:

Hertzberg, J.B., Zhang, E.J., Rosenblatt, S. et al. Laser-annealing Josephson junctions for yielding scaled-up superconducting quantum processors. npj Quantum Inf 7, 129 (2021). https://doi.org/10.1038/s41534-021-00464-5

TODOs:

  • Add tests
  • Improve docs

Co-authored-by: Toshinari Itoko itoko@jp.ibm.com
Co-authored-by: Naoki Kanazawa nkanazawa1989@gmail.com

Co-authored-by: Sitong Liu <Sitong.Liu@ibm.com>
Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com>
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Aug 26, 2022
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2963862732

  • 0 of 129 (0.0%) changed or added relevant lines in 1 file are covered.
  • 177 unchanged lines in 17 files lost coverage.
  • Overall coverage decreased (-0.1%) to 83.976%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/transpiler/passes/analysis/frequency_collision.py 0 129 0.0%
Files with Coverage Reduction New Missed Lines %
qiskit/circuit/library/standard_gates/z.py 1 98.55%
qiskit/circuit/library/standard_gates/s.py 2 97.1%
qiskit/extensions/quantum_initializer/squ.py 2 79.78%
qiskit/transpiler/passmanager_config.py 2 96.88%
qiskit/utils/deprecation.py 2 93.33%
qiskit/pulse/library/waveform.py 3 89.36%
qiskit/transpiler/preset_passmanagers/common.py 4 96.64%
qiskit/transpiler/preset_passmanagers/level1.py 5 95.8%
qiskit/algorithms/optimizers/gradient_descent.py 6 92.86%
qiskit/transpiler/preset_passmanagers/level0.py 6 93.1%
Totals Coverage Status
Change from base Build 2931036529: -0.1%
Covered Lines: 56987
Relevant Lines: 67861

💛 - Coveralls

@nonhermitian
Copy link
Contributor

There is a related PR at the mapomatic repo: qiskit-community/mapomatic#44

@mtreinish
Copy link
Member

We recently merged #9026 which added an interface for custom analysis passes that set custom values for the heuristic scoring in the vf2 passes. It might make integrating this a bit easier, you can define a new analysis pass that builds an ErrorMap object with different error rates for each qubit and 2q link in the coupling graph and set that on the property set that as vf2_avg_error_map in the property set. Then when VF2Layout and/or VF2PostLayout are run it will use that error map for scoring instead of the one generated from the backend properties.

@1ucian0 1ucian0 added the Intern PR PR submitted by IBM Quantum interns label Apr 25, 2023
@itoko itoko changed the title Add frequency collision-aware layout passes Add frequency collision analysis pass May 8, 2023
@itoko
Copy link
Contributor

itoko commented May 8, 2023

I've just diminished the scope of this PR so that it just adds an analysis pass that enumerates frequency collisions (excluding layout passes using the information of frequency collisions). I think having such a pass is still useful for users who wants to know about the frequency collisions in a backend of interest. Any thoughts on having it in Terra? Should it live somewhere not in Terra? @nkanazawa1989 @mtreinish @nonhermitian

@itoko
Copy link
Contributor

itoko commented Sep 22, 2023

Let me close this draft PR as it is stalled and plugin transpiler passes (like CollisionAnalysis introduced in this PR) are now supposed to be in some repository under qiskit-community organization first.

@itoko itoko closed this Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community PR PRs from contributors that are not 'members' of the Qiskit repo Intern PR PR submitted by IBM Quantum interns
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants