Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ParameterExpression is killing the Performance of Parameter.bind #5042

Closed
eliphatfs opened this issue Sep 8, 2020 · 1 comment
Closed

ParameterExpression is killing the Performance of Parameter.bind #5042

eliphatfs opened this issue Sep 8, 2020 · 1 comment
Labels
type: enhancement It's working, but needs polishing

Comments

@eliphatfs
Copy link

What is the expected enhancement?

I am doing a problem where parameters would be assigned very frequently, and the performance is not quite satisfactory. After profiling I found that subs (from sympy) counts for 1.84s out of 2.09s in QuantumCircuit._bind_parameter during my profiled session. It even takes more time than the simulation itself (0.13s), which is not acceptable.
In most cases (where the expression is a single variable), there could be some shortcuts that moves away from the costly symbolic operations.
@eliphatfs eliphatfs added the type: enhancement It's working, but needs polishing label Sep 8, 2020
@hhorii hhorii mentioned this issue Sep 9, 2020
Closed
@1ucian0
Copy link
Member

1ucian0 commented Dec 13, 2021

Probably fixed via #6270 . Please reopen if the problem is still there.

@1ucian0 1ucian0 closed this as completed Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement It's working, but needs polishing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use lambdify instead of subs in ParameterExpression.bind() hhorii/qiskit-terra
2 participants
@1ucian0 @eliphatfs