Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test suite should error on unexpected warnings #6904

Open
levbishop opened this issue Aug 13, 2021 · 0 comments
Open

Test suite should error on unexpected warnings #6904

levbishop opened this issue Aug 13, 2021 · 0 comments
Labels
type: enhancement It's working, but needs polishing type: qa Issues and PRs that relate to testing and code quality

Comments

@levbishop
Copy link
Member

levbishop commented Aug 13, 2021 •
edited
Loading

Since #6392 we explicitly check for unfiltered DeprecationWarning but other types of warning do also indicate an issue that should be investigated, and might be missed due to all the text scrolling past during a test-suite run. (This happened for #6553 (comment))

If the performance hit isn't too terrible we might consider running the test suite in python development (-X dev) mode to enable some additional more-expensive checking.
@levbishop levbishop added type: enhancement It's working, but needs polishing type: qa Issues and PRs that relate to testing and code quality labels Aug 13, 2021
@levbishop levbishop mentioned this issue Oct 7, 2021
Closed
This was referenced Oct 26, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement It's working, but needs polishing type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@levbishop