Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previous Versions URLs should preserve the language chosen #290

Closed
Eric-Arellano opened this issue May 2, 2023 · 3 comments
Closed

Previous Versions URLs should preserve the language chosen #290

Eric-Arellano opened this issue May 2, 2023 · 3 comments
Assignees

Comments

@Eric-Arellano
Copy link
Collaborator

We always will switch to an English version. That is annoying for other languages.

This would look like improving the logic in #267 to handle when locale/bn_BN is in the URL, e.g. https://qiskit.org/documentation/locale/bn_BN/index.html. The change should use test driven development by modifying our Jest tests.

@Eric-Arellano Eric-Arellano self-assigned this May 2, 2023
@Eric-Arellano
Copy link
Collaborator Author

Eric-Arellano commented May 11, 2023

This should be much easier thanks to #321.

But, it is a little risky to add this feature because the locale may have not existed in prior versions of the docs. That would result in a 404.

@Eric-Arellano Eric-Arellano added this to the Theme v1.12.0 milestone May 11, 2023
@Eric-Arellano
Copy link
Collaborator Author

@coruscating had a great suggestion based on Python docs:

They will show an English page for an untranslated older version page.

We'd have to change our workflow to render all pages for different languages even if they're not translated though

@Eric-Arellano Eric-Arellano removed this from the Theme v1.12.0 milestone May 12, 2023
@Eric-Arellano
Copy link
Collaborator Author

We don't version translations. https://qiskit.org/documentation/locale/fr_FR/stable/0.43/index.html and https://qiskit.org/documentation/stable/locale/fr_FR/0.43/index.html don't exist. So this is not even relevant.

It would be good to deploy translations for previous versions of the docs. But given that the docs are moving, this should be part of that new infrastructure rather than done via qiskit-sphinx-theme.

@Eric-Arellano Eric-Arellano closed this as not planned Won't fix, can't repro, duplicate, stale Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

No branches or pull requests

1 participant