Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hsl2hsv returns NaN #14

Closed
rickyvetter opened this issue Jun 2, 2015 · 0 comments · Fixed by #15
Closed

hsl2hsv returns NaN #14

rickyvetter opened this issue Jun 2, 2015 · 0 comments · Fixed by #15

Comments

@rickyvetter
Copy link
Contributor

If [0,0,0] is passed into hsl2hsv, [0,NaN,0] is returned because of a divide by 0 error here sv = (2 * s) / (l + s);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check for 0 on hsl2hsv and tests rickyvetter/color-convert
1 participant
@rickyvetter