Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'=' does not work properly for DataType::Union #105

Closed
vserret opened this issue Sep 8, 2023 · 1 comment
Closed

'=' does not work properly for DataType::Union #105

vserret opened this issue Sep 8, 2023 · 1 comment

Comments

@vserret
Copy link
Contributor

vserret commented Sep 8, 2023

This test does not pass

#[test]
    fn test_equalities_union_struct() {
        let s1 = DataType::structured([
            ("a", DataType::float()),
            ("b", DataType::float()),
        ]);
        let s2 = DataType::structured([
            ("a", DataType::boolean()),
            ("b", DataType::integer()),
        ]);
        assert!(s1 != s2);

        let u1 = DataType::union([
            ("table1", s1.clone()),
            ("table2", s2.clone()),
        ]);
        let u2 = DataType::union([
            ("table1", s1.clone()),
            ("table2", s1.clone()),
        ]);
        assert!(u1 != u2)
    }
@vserret
Copy link
Contributor Author

vserret commented Sep 11, 2023

Fixed in #106

@vserret vserret closed this as completed Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant